Add semver2 support to npm #237
Conversation
- An optional third paramater is added to setPackageVersion to specifiy the version of semver to use. The default value is 1 to retain backwards compatibility.
|
I'm interested to know thoughts. I'm not terribly happy that in order to use semver2 you must provide all 3 parameters, even though others are optional. Perhaps a better solution would be to support a string or options object as the first parameter. If options are provided, they take precedence, even if a 2nd parameter is passed. |
| */ | ||
| export async function setPackageVersion(packageDirectory?: string, srcDirectory?: string) { | ||
| export async function setPackageVersion(packageDirectory?: string, srcDirectory?: string, semVer: 1 | 2 = 1) { |
There was a problem hiding this comment.
Rather than a parameter, can we follow the pattern we use for NuGet packages, by adding a field to version.json to indicate which semver version to use?
https://github.com/AArnott/Nerdbank.GitVersioning/blob/master/doc/versionJson.md
There was a problem hiding this comment.
Sounds good; I'll look into it. In the meantime, I've opened #238 which just includes the typescript upgrade, typings removal and some other minor cleanup changes.
|
This PR hasn't been updated in a month. Closing. I'll preparing the change I asked for myself. But I've added questions to the original issue that I need to get answers for. |
to specifiy the version of semver to use. The default value is 1
to retain backwards compatibility.
fixes #236