Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and re-enable NativeVersionInfo_CreateNativeResourceDll for AzurePipelines #296

Merged
merged 5 commits into from
Feb 2, 2019

Conversation

japj
Copy link
Contributor

@japj japj commented Feb 2, 2019

Fixes #294

@japj
Copy link
Contributor Author

japj commented Feb 2, 2019

hmm, it seems the pipeline build is behaving differently than local build from VS/with init.cmd/build.cmd
I didn't notice the additional warning before (which the pipeline is apparently treating as an error)

@AArnott
Copy link
Collaborator

AArnott commented Feb 2, 2019

Yes I treat all the warnings as errors in the official versions. Feel free to scale back on the packages you updated if it's unrelated to your goal and would help you fix the problem.

@japj
Copy link
Contributor Author

japj commented Feb 2, 2019

This should fix the last warnings, but I don't know if/how I trigger a new AzurePipeline to verify again
(the pipeline was automatically triggered for previous updates of the pull request?)

@AArnott AArnott merged commit 3a0f320 into dotnet:master Feb 2, 2019
@AArnott
Copy link
Collaborator

AArnott commented Feb 2, 2019

Thanks

AArnott added a commit that referenced this pull request Feb 2, 2019
This reverts commit 3a0f320, reversing
changes made to 83553ce.
AArnott added a commit that referenced this pull request Feb 2, 2019
@AArnott
Copy link
Collaborator

AArnott commented Feb 2, 2019

Evidently the browser on my phone lied (probably a stale web page) and said the build was successful when in fact the test had failed. So I had to revert this PR. The new one is #297. Can you follow up to get the test actually working, @japj ?

Thanks.

@japj
Copy link
Contributor Author

japj commented Feb 2, 2019

yeah, it's weird apparently the new build did not trigger after updated push (like I wrote in the comments)

The other issue is that I cannot yet reproduce the issue locally, so I will do analysis on the actual pipeline logging to see if I understand what this is caused by.

@AArnott
Copy link
Collaborator

AArnott commented Feb 3, 2019

Thanks.

AArnott pushed a commit that referenced this pull request Feb 3, 2019
…Pipelines

Reapply "Merge pull request #296 from japj/fix294"

This reverts commit e442089.
AArnott added a commit that referenced this pull request Feb 3, 2019
Reapply "Merge pull request #296 from japj/fix294"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants