Upgrade to VS2017 RC.3 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <PackageTags>aspnetcore;codegenerator;scaffolding;visualstudioweb</PackageTags> | ||
| <PackageTargetFallback Condition=" '$(TargetFramework)' == 'netstandard1.6' ">$(PackageTargetFallback);portable-net45+win8</PackageTargetFallback> | ||
| <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences> |
There was a problem hiding this comment.
What references are disabled due to this?
There was a problem hiding this comment.
NETStandard.Library. It's not currently building with this as a package reference. We will didn't start doing this until the 1.1 train.
| <PackageTags>aspnetcore;aspnetcoremvc;codegenerator;scaffolding;visualstudioweb</PackageTags> | ||
| <PackageTargetFallback Condition=" '$(TargetFramework)' == 'netstandard1.6' ">$(PackageTargetFallback);portable-net45+win8</PackageTargetFallback> | ||
| <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences> |
There was a problem hiding this comment.
Can we move this to build/common.props? or does this conflict with the
<NetCoreAppImplicitPackageVersion>1.0.0</NetCoreAppImplicitPackageVersion>
There was a problem hiding this comment.
Unfortunately, it will disable the implicit package reference, regardless of NetCoreAppImplicitPackageVersion's existence
|
Btw, I'm investigating the failures. I think there are still lingering effects of NuGet/Home#4321 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes lots of unnecessary code from csproj files.