Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A proposal for Bindings Owners to allow more bindings into Silk.NET #2030

Merged
merged 7 commits into from
Jan 27, 2025
Merged

A proposal for Bindings Owners to allow more bindings into Silk.NET #2030

merged 7 commits into from
Jan 27, 2025

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Apr 12, 2024

Just read the proposal, I promise this isn't scope creep.

@Perksey Perksey marked this pull request as ready for review April 12, 2024 04:58
@Perksey Perksey requested a review from a team as a code owner April 12, 2024 04:58
@Perksey
Copy link
Member Author

Perksey commented Apr 12, 2024

This is ready for a pre-WG review.

Beyley
Beyley reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@Beyley Beyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my initial glance all is pona tawa mi

@Perksey Perksey added this to the Next Working Group Meeting milestone Apr 12, 2024
@Perksey Perksey mentioned this pull request Aug 8, 2024
Open
@Perksey
Copy link
Member Author

Perksey commented Jan 26, 2025

  • Approved subject to these comments.
  • Version suffixes should be used for betas, specifically for bindings that are not quite stable but still meet the requirements. Those suffixes apply only to those additional binding nuget packages.

@Perksey Perksey merged commit 443f99f into main Jan 27, 2025
6 of 36 checks passed
@Perksey Perksey deleted the proposal/bindings-owners branch January 27, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beyley Beyley Beyley left review comments

@joskuijpers joskuijpers joskuijpers left review comments

@aquagoose aquagoose aquagoose approved these changes

@ThomasMiz ThomasMiz ThomasMiz approved these changes

@curin curin curin approved these changes

@alexrp alexrp alexrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Silk.NET Development Tracker
Status: Done
Milestone
Next Working Group Meeting
Development

Successfully merging this pull request may close these issues.
7 participants
@Perksey @alexrp @curin @joskuijpers @ThomasMiz @Beyley @aquagoose