-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move into Shared SqlDependencyListener.cs #1308
Move into Shared SqlDependencyListener.cs #1308
Conversation
…d update reference in the csprojs, fix compiler error for netfx in SqlDependency.cs
…IDE1006, and IDE0059
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependencyListener.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependencyListener.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Johnny Pham <[email protected]>
Some events were using |
I noticed that too. I'm not sure if we need to unify those and if so which one should we be using. |
@lcheunglci can you address the conflict please? |
After a discussion with @cheenamalhotra and @JRahnama , I believe the consensus is to use the one from netfx. I'll make the updates in the next commit. |
NIT: @lcheunglci There are 'new' expression simplification info suggestions for line 87,1636,1713. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reset branch to contain only PR related changes.
442930f
to
a21542f
Compare
Relates to #1261 . Merged netfx to netcore and move it to shared src. While cleaning up the coding style errorlist, I left 2 IDE0063 (Line 957 and Line 1076) info messages because I chose to keep the scope bodied using statement and there was a IDE0079 suggesting that I remove the suppression of
CA2100:ReviewSqlQueriesForSecurityVulnerabilities
on Line 968, which I left. I may need to merge PR #1299 because there's a small change to the property to the property to retrieve the static instance ofSingletonProcessDispatcher
.