Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix test intermittent issues by including source link package for release build only #1325

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Attempt to fix test intermittent issues by including source link package for release build only #1325

merged 1 commit into from
Oct 8, 2021

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@cheenamalhotra cheenamalhotra added the Area\Tests Issues that are targeted to tests or test projects label Oct 7, 2021
@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview3 milestone Oct 7, 2021
@DavoudEshtehari
Copy link
Contributor

It's not related to your change, but could I ask you to update the LangVersion in Microsoft.Cci.Extensions.csproj?

@DavoudEshtehari
Copy link
Contributor

DavoudEshtehari commented Oct 7, 2021 •
edited
Loading

The csproj files are not correct. It's weird, GitHub doesn't show those changes. I guess you're not on the latest changes.

@cheenamalhotra
Copy link
Member Author

cheenamalhotra commented Oct 7, 2021 •
edited
Loading

It's not related to your change, but could I ask you to update the LangVersion in Microsoft.Cci.Extensions.csproj?

We can do that in a separate PR.

The csproj files are not correct. It's weird, GitHub doesn't show those changes. I guess you're not on the latest changes.

That does not matter, when Pipeline Jobs are built, PRs are merged to main and then checked out. This is why conflicting changes don't build.

@cheenamalhotra cheenamalhotra merged commit 8476c8e into dotnet:main Oct 8, 2021
@cheenamalhotra cheenamalhotra deleted the testfix branch April 24, 2023 18:08
@JRahnama JRahnama mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@lcheunglci lcheunglci lcheunglci approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

Assignees
No one assigned
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.
3 participants
@cheenamalhotra @DavoudEshtehari @lcheunglci