Feature | Project Microsoft.SqlServer.Server separation phase 2 (MDS consumes MSS using netcore) #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
added
the
🆕 Public API
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
DavoudEshtehari
force-pushed
the
MSqlServerSep2
branch
2 times, most recently
from
a8c7f91 to
01fa0a5
Compare
DavoudEshtehari
requested review from
JRahnama,
johnnypham,
Kaur-Parminder and
David-Engel
DavoudEshtehari
force-pushed
the
MSqlServerSep2
branch
from
01fa0a5 to
cced872
Compare
David-Engel
reviewed
Apr 21, 2022
David-Engel
approved these changes
Apr 22, 2022
|
You may want to add dependency in Microsoft.Data.SqlClient.nuspec for non-netfx targets to be able to reference Microsoft.SqlServer.Server released version from external apps. |
David-Engel
approved these changes
May 27, 2022
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj # src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs
Kaur-Parminder
approved these changes
Jun 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
+ Coverage 71.28% 71.34% +0.05%
==========================================
Files 296 290 -6
Lines 61161 61048 -113
==========================================
- Hits 43600 43554 -46
+ Misses 17561 17494 -67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JRahnama
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping the Microsoft.Data.SqlClient.Server namespace for supported types by Microsoft.SqlServer.Server package.
Any attempt to use the common types from Microsoft.SqlServer.Server and System.Data.SqlClient packages are known conflicts.