Fix | Handle NRE on Azure federated authentication #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
added
the
🐛 Bug!
DavoudEshtehari
force-pushed
the
Adhoc/FedAuthNRE
branch
from
f8f6e45 to
4c419c5
Compare
DavoudEshtehari
changed the title
David-Engel
reviewed
May 27, 2022
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
- Coverage 71.39% 71.31% -0.09%
==========================================
Files 296 295 -1
Lines 62146 61203 -943
==========================================
- Hits 44370 43644 -726
+ Misses 17776 17559 -217
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
David-Engel
approved these changes
May 31, 2022
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlUtil.cs
Show resolved
Hide resolved
They're a lot to improve, and if you check the possible merging codebases those are listed there. So, I'd rather don't mix them up with this change. |
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.resx
JRahnama
approved these changes
Jun 6, 2022
David-Engel
added a commit
to David-Engel/SqlClient
that referenced
this pull request
Aug 5, 2022
Porting dotnet#1625 to 3.1-servicing.
David-Engel
added a commit
to David-Engel/SqlClient
that referenced
this pull request
Aug 6, 2022
Porting dotnet#1625 to 3.1-servicing.
David-Engel
added a commit
that referenced
this pull request
Aug 9, 2022
Porting #1625 to 3.1-servicing.
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 11, 2022
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.Designer.cs # src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.resx # src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Aug 15, 2022
# Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.Designer.cs # src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.resx # src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs
DavoudEshtehari
added a commit
that referenced
this pull request
Aug 23, 2022
DavoudEshtehari
added a commit
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications owned and operated by Microsoft must get approval from the API owner before requesting tokens for that API, otherwise, the token won't be resolved.