Code Health | Enforcing Ordinal for StringComparison

[JRahnama]

@Wraith2: based on the other conversation we had on PR #2065, what do you think on this change request?

[ErikEJ]

I was just going to ask if there were other potential relevant changes - LGTM

[Wraith2]

Looks like a good idea to me.

[David-Engel]

To add background for anyone investigating this in the future: In a library like MDS, almost all string comparison operations being done inside the library should not use culture comparison rules (they should use Ordinal). For example, if we are parsing a connection string, we are looking for specific characters, not culture-specific representations of them. For example, if we are looking for a comma (also a thousands separator in some languages), we only want to find a comma, not a period (also a thousands separator in some languages). Default string comparison operations in .NET are culture specific. To be safe, we should always be explicit with which option we want to use inside MDS.

[codecov]

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.19 ⚠️

Comparison is base (2b31810) 70.79% compared to head (ee12d1f) 70.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
- Coverage   70.79%   70.61%   -0.19%     
==========================================
  Files         305      305              
  Lines       61819    61819              
==========================================
- Hits        43764    43652     -112     
- Misses      18055    18167     +112     

Flag	Coverage Δ
addons	92.88% <ø> (ø)
netcore	73.35% <77.77%> (-0.17%)	⬇️
netfx	69.25% <66.66%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../Microsoft/Data/Common/DbConnectionStringCommon.cs	64.51% <ø> (ø)
...rc/Microsoft/Data/SqlClient/SqlConnectionString.cs	72.01% <0.00%> (-2.47%)	⬇️
...tcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs	49.46% <50.00%> (ø)
...qlClient/SqlColumnEncryptionCngProvider.Windows.cs	100.00% <100.00%> (ø)
...qlClient/SqlColumnEncryptionCspProvider.Windows.cs	99.14% <100.00%> (ø)
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs	68.23% <100.00%> (-0.35%)	⬇️
...c/Microsoft/Data/SqlTypes/SqlFileStream.Windows.cs	53.61% <100.00%> (ø)
...SqlClient/ActiveDirectoryAuthenticationProvider.cs	59.57% <100.00%> (ø)
...src/Microsoft/Data/SqlClient/SqlSecurityUtility.cs	79.02% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.