Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1.6] | Fix CodeQL and Rozlyn warnings (#2428) and (#2432) #2515

Merged
merged 2 commits into from
May 17, 2024

Fix | Suppress CodeQL X509RevocationMode warning. (#2432)

d20f231
Select commit
Loading
Failed to load commit list.
Merged

[3.1.6] | Fix CodeQL and Rozlyn warnings (#2428) and (#2432) #2515

Fix | Suppress CodeQL X509RevocationMode warning. (#2432)
d20f231
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Release 3.1 failed May 17, 2024 in 1h 1m 43s

Build #88445 had test failures

Details

Tests

  • Failed: 2,330 (8.67%)
  • Passed: 22,006 (81.89%)
  • Other: 2,535 (9.43%)
  • Total: 26,871

Annotations

Check failure on line 19519 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Build log #L19519

Error: The process 'C:\Program Files\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 19524 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Build log #L19524

Dotnet command failed with non-zero exit code on the following projects : [
  'D:\\a\\_work\\1\\s\\src\\Microsoft.Data.SqlClient\\tests\\ManualTests\\Microsoft.Data.SqlClient.ManualTesting.Tests.csproj'
]

Check failure on line 19535 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Build log #L19535

Error: Failed rmRF: EPERM: operation not permitted, unlink 'D:\a\_work\_temp\cloudtest_45ce5962c000003_2024-05-17_19_01_11.trx'

Check failure on line 39013 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Build log #L39013

Error: The process 'C:\Program Files\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlBulkCopyTruncation.BulkCopyVarchar(connectionString: "Data Source=adotest.database.windows.net;Initial C"...)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlBulkCopyTruncation.BulkCopyVarchar(connectionString: "Data Source=adotest.database.windows.net;Initial C"...)

Microsoft.Data.SqlClient.SqlException : Login failed for user 'dotnet'.
Raw output
   at Microsoft.Data.ProviderBase.DbConnectionPool.CheckPoolBlockingPeriod(Exception e) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.NetCoreApp.cs:line 18
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 822
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1761
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1162
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1108
   at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionFactory.cs:line 122
   at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions) in /_/src/Microsoft.Data.SqlClient/netcore/src/Common/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs:line 348
   at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 1753
   at Microsoft.Data.SqlClient.SqlRetryLogicProvider.Execute[TResult](Object sender, Func`1 function) in /_/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Reliability/Common/SqlRetryLogicProvider.cs:line 63
   at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 1305
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlBulkCopyTruncation.DoBulkCopy(String sourceTable, String targetTable, String connectionString) in /mnt/vss/_work/1/s/src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/SqlBulkCopyTruncation.cs:line 571
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlBulkCopyTruncation.BulkCopyVarchar(String connectionString) in /mnt/vss/_work/1/s/src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/SqlBulkCopyTruncation.cs:line 288

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlNullValuesTests.NullValueTests(connString: "Data Source=adotest.database.windows.net;Initial C"..., connStringSetting: 1, commandSetting: 2, nullReturnValue: Null)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlNullValuesTests.NullValueTests(connString: "Data Source=adotest.database.windows.net;Initial C"..., connStringSetting: 1, commandSetting: 2, nullReturnValue: Null)

Microsoft.Data.SqlClient.SqlException : Login failed for user 'dotnet'.
Raw output
   at Microsoft.Data.ProviderBase.DbConnectionPool.CheckPoolBlockingPeriod(Exception e) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.NetCoreApp.cs:line 18
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 822
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1761
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1162
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1108
   at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionFactory.cs:line 122
   at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions) in /_/src/Microsoft.Data.SqlClient/netcore/src/Common/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs:line 348
   at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 1753
   at Microsoft.Data.SqlClient.SqlRetryLogicProvider.Execute[TResult](Object sender, Func`1 function) in /_/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Reliability/Common/SqlRetryLogicProvider.cs:line 63
   at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 1305
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlNullValuesTests.NullValueTests(String connString, ConnStringColumnEncryptionSetting connStringSetting, SqlCommandColumnEncryptionSetting commandSetting, ReturnValueSetting nullReturnValue) in /mnt/vss/_work/1/s/src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/SqlNullValues.cs:line 81

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.BulkCopyAEErrorMessage.TextToIntErrorMessageTest(connectionString: "Data Source=adotest.database.windows.net;Initial C"...)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.BulkCopyAEErrorMessage.TextToIntErrorMessageTest(connectionString: "Data Source=adotest.database.windows.net;Initial C"...)

Unexpected error message: Login failed for user 'dotnet'.
Expected: True
Actual:   False
Raw output
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.BulkCopyAEErrorMessage.StringToIntTest(String connectionString, String targetTable, Object dataSet, String value, Int32 rowNo, String targetType) in /mnt/vss/_work/1/s/src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/BulkCopyAEErrorMessage.cs:line 106
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.BulkCopyAEErrorMessage.TextToIntErrorMessageTest(String connectionString) in /mnt/vss/_work/1/s/src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/BulkCopyAEErrorMessage.cs:line 35

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlNullValuesTests.NullValueTests(connString: "Data Source=adotest.database.windows.net;Initial C"..., connStringSetting: 2, commandSetting: 0, nullReturnValue: NotNull)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Release 3.1

Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlNullValuesTests.NullValueTests(connString: "Data Source=adotest.database.windows.net;Initial C"..., connStringSetting: 2, commandSetting: 0, nullReturnValue: NotNull)

Microsoft.Data.SqlClient.SqlException : Login failed for user 'dotnet'.
Raw output
   at Microsoft.Data.ProviderBase.DbConnectionPool.CheckPoolBlockingPeriod(Exception e) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.NetCoreApp.cs:line 18
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 822
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1761
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1162
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs:line 1108
   at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionFactory.cs:line 122
   at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions) in /_/src/Microsoft.Data.SqlClient/netcore/src/Common/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs:line 348
   at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 1753
   at Microsoft.Data.SqlClient.SqlRetryLogicProvider.Execute[TResult](Object sender, Func`1 function) in /_/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Reliability/Common/SqlRetryLogicProvider.cs:line 63
   at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides) in /_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs:line 1305
   at Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.SqlNullValuesTests.NullValueTests(String connString, ConnStringColumnEncryptionSetting connStringSetting, SqlCommandColumnEncryptionSetting commandSetting, ReturnValueSetting nullReturnValue) in /mnt/vss/_work/1/s/src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/SqlNullValues.cs:line 81