Mark InternalException, NetEventSource & SecPkgContext_ApplicationProtocol as .NET 6.0-only #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InternalException, NetEventSource and the types associated with SecPkgContext_ApplicationProtocol are only used by the old .NET 6.0 target.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
==========================================
- Coverage 72.31% 72.29% -0.02%
==========================================
Files 288 288
Lines 59660 59660
==========================================
- Hits 43145 43134 -11
- Misses 16515 16526 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benrr101
approved these changes
Nov 4, 2024
We'll take in changes as much as we can get accomplished. |
cheenamalhotra
approved these changes
Nov 4, 2024
mdaigle
added
the
Common Project 🚮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up from the comments on #2828, to resolve the merge race between @benrr101, @mdaigle and I.
InternalException, NetEventSource and the types associated with SecPkgContext_ApplicationProtocol are only used by the old .NET 6.0 target. This PR guards these behind
#if NET && !NET8_0_OR_GREATER, ready to join the rest of the .NET 6.0-only files and types when they're removed.Is the removal of the .NET 6.0-only code already in motion, or will this happen after the SqlClient 6.0 release?