Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align comments between netfx and netcore codebases #2966

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 2, 2024

Hopefully an easy to review PR that deals with differences in comments and some whitespace between netfx and netcore for easier future merging

Part of #2965

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rollback the change for EditorBrowsableAttribute if we don't have a strong reason to move it over.

Also, in the future, please just combine all the comment cleanup changes into a single PR.

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Nov 4, 2024
@benrr101
Copy link
Contributor

benrr101 commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (9d5ca32) to head (c3e79a9).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2966      +/-   ##
==========================================
- Coverage   72.31%   72.29%   -0.03%     
==========================================
  Files         288      288              
  Lines       59660    59660              
==========================================
- Hits        43145    43133      -12     
- Misses      16515    16527      +12     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.39% <100.00%> (-0.04%) ⬇️
netfx 70.68% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheenamalhotra cheenamalhotra merged commit ca1a943 into dotnet:main Nov 6, 2024
76 checks passed
@cheenamalhotra cheenamalhotra added this to the 6.0-preview3 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants