Remove SQL 2000 client-side debugging support #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also recurses down into NativeMethods.cs, to help clean up PInvokes.
|
Uhhhhhhhhhhhhhhhhhhhhhhhhhhh 😅 |
benrr101
added
the
Common Project 🚮
|
No worries - I'll just merge back into my branch once #2997 is done. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2981 +/- ##
==========================================
+ Coverage 72.48% 72.56% +0.07%
==========================================
Files 288 288
Lines 59493 59385 -108
==========================================
- Hits 43123 43091 -32
+ Misses 16370 16294 -76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benrr101
approved these changes
Nov 14, 2024
|
#2839 next! :) |
David-Engel
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #2940, removing the client-side support for SQL 2000's debugging mechanisms from netfx and aligning with netcore.
The SqlConnection diff will be easier to parse with whitespace changes disabled. I've removed the methods which enable the now-defunct debugging, the
SqlDebugContextclass andMEMMAPstruct which they use and the PInvokes they reference. These PInvokes were the only thing innetfx\src\Microsoft\Data\Common\NativeMethods.cs, so I've deleted the file.This isn't critical for preview3.
/cc @benrr101 - there's no need to port PInvokes from NativeMethods.cs anywhere. It's the same story for the SafeNativeMethods.cs file in the same folder.