Remove code that is unused in .NET 8 #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"I love the smell of dead code in the morning" 😄 |
|
Should also fix #303 I think |
ErikEJ
reviewed
Nov 8, 2024
| @@ -217,9 +217,6 @@ | |||
| <Compile Include="$(CommonSourceRoot)Microsoft\Data\ProviderBase\TimeoutTimer.cs"> | |||
| <Link>Microsoft\Data\ProviderBase\TimeoutTimer.cs</Link> | |||
| </Compile> | |||
| <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\SSPI\ManagedSSPIContextProvider.cs"> | |||
There was a problem hiding this comment.
Were these files not used in .NET Framework?
There was a problem hiding this comment.
That is the #IF NET6_0 file... so while it was referenced, it was not compiled for netfx
ErikEJ
reviewed
Nov 8, 2024
| @@ -9,9 +9,8 @@ internal static partial class Libraries | |||
| internal const string Kernel32 = "kernel32.dll"; | |||
| internal const string NtDll = "ntdll.dll"; | |||
| #if !NET8_0_OR_GREATER | |||
There was a problem hiding this comment.
The tests use that in multiple locations in SecurityWrapper.cs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2991 +/- ##
==========================================
+ Coverage 72.47% 72.50% +0.02%
==========================================
Files 288 288
Lines 59498 59498
==========================================
+ Hits 43124 43141 +17
+ Misses 16374 16357 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benrr101
approved these changes
Nov 14, 2024
benrr101
added
the
➕ Code Health
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's code marked as !NET8_0_OR_GREATER in the netcore project, or NET && !NET8_0_OR_GREATER in the shared project that can be removed, now that the only supported .NET (Core) version is 8+