perf: Add cached SqlReferenceCollection find delegate and context objects #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
added
the
📈 Performance
|
Any feedback @cheenamalhotra @David-Engel ? |
David-Engel
approved these changes
Feb 24, 2020
Wraith2
force-pushed
the
perf-refcollectionfind
branch
from
d995624 to
dcff145
Compare
cheenamalhotra
approved these changes
Feb 26, 2020
|
The changes look good to me, but I don't think this code path is even tested currently. The code coverage shall drop otherwise. |
|
|
cheenamalhotra
pushed a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking to see if there is a live command or reader associated with a connection (which in any sane program is almost always a negative result) a delegate and in some cases a closure are allocated. These can be avoided most of the time by using a static cached delegate and allowing reuse of a single context object if it is available.