Add "Transaction Id" and "Client Version" in Diagnostic Source traces #515
+59
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing request made by @davidmikh here: #93 (comment)
Hi @davidmikh
As per our offline discussions, I've made this PR to include "Transaction Id" to
SqlCommand
andSqlTransaction
events and "Client Version" inSqlConnection
events.Regarding other 2 requests:
SqlTransaction
events--
Connection.ClientConnectionId
contains this info.SqlConnection
open events--
Connection.ServerVersion
contains this info.Let me know if you need additional info from here.
P.S. Diagnostic Tests to be enabled in a separate PR (WIP @JRahnama PR #517)