Optional ORDER hints for SqlBulkCopy #540

johnnypham · 2020-04-24T22:00:25Z

ORDER ( { column [ ASC | DESC ] } [ ,... n ] ) Specifies how the data in the data file is sorted. Bulk import performance is improved if the data being imported is sorted according to the clustered index on the table, if any. If the data file is sorted in a different order, that is other than the order of a clustered index key or if there is no clustered index on the table, the ORDER clause is ignored. The column names supplied must be valid column names in the destination table. By default, the bulk insert operation assumes the data file is unordered. For optimized bulk import, SQL Server also validates that the imported data is sorted.

insert bulk, which SqlBulkCopy uses, will return an error message when an ORDER hint is given for an identity column and the query is not executed. This differs from BULK INSERT, which ignores the ORDER hint but still executes the query.

dnfclas · 2020-04-24T22:00:38Z

All CLA requirements met.

doc/samples/SqlBulkCopy_ColumnOrderHint.cs

doc/samples/SqlBulkCopy_ColumnOrderHintColumn.cs

doc/samples/SqlBulkCopy_ColumnOrderHintSortOrder.cs

doc/snippets/Microsoft.Data.SqlClient/SqlBulkCopyColumnOrderHint.xml

src/Microsoft.Data.SqlClient.sln

src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.resx

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlBulkCopyColumnOrderHintCollectionTest.cs

...crosoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/OrderHintMissingTargetColumn.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/OrderHint.cs

doc/snippets/Microsoft.Data.SqlClient/SqlBulkCopyColumnOrderHint.xml

src/Microsoft.Data.SqlClient.sln

...icrosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnOrderHintCollection.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/SqlBulkCopyTest.cs

mistake!

src/Microsoft.Data.SqlClient.sln

…Server overloads. Fixed XML mistakes

…lClient into bulkCopyOrderHints

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlBulkCopyColumnOrderHintCollectionTest.cs

...icrosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnOrderHintCollection.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/OrderHint.cs

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/SqlBulkCopyTest.cs

src/Microsoft.Data.SqlClient.sln

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlBulkCopyColumnOrderHintCollectionTest.cs

…lClient into bulkCopyOrderHints

This reverts commit 9cde0c4.

…ypham/SqlClient into bulkCopyOrderHints" This reverts commit 0093a06, reversing changes made to 9cde0c4.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlBulkCopyColumnOrderHintCollectionTest.cs

...icrosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnOrderHintCollection.cs

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs

doc/snippets/Microsoft.Data.SqlClient/SqlBulkCopy.xml

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlBulkCopy.cs

...icrosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnOrderHintCollection.cs

Johnny Pham added 2 commits April 23, 2020 23:45

order hint implementation

e431f08

minor changes

84ec1ab

johnnypham added the 🆕 Public API Issues/PRs that introduce new APIs to the driver. label Apr 24, 2020

JRahnama reviewed Apr 27, 2020

View reviewed changes

Johnny Pham and others added 4 commits April 27, 2020 12:06

minor changes

bef48f6

Update Microsoft.Data.SqlClient.sln

51b37d8

modified tests

eb82141

modified tests

d214355

DavoudEshtehari previously approved these changes Apr 28, 2020

View reviewed changes

DavoudEshtehari self-requested a review April 28, 2020 02:40

JRahnama reviewed Apr 28, 2020

View reviewed changes

src/Microsoft.Data.SqlClient.sln Outdated Show resolved Hide resolved

Johnny Pham added 3 commits April 28, 2020 16:22

Tests now use DataTestUtility to drop tables. Added tests for WriteTo…

b25e3c8

…Server overloads. Fixed XML mistakes

Merge branch 'bulkCopyOrderHints' of https://github.com/johnnypham/Sq…

8834023

…lClient into bulkCopyOrderHints

assigned task number to order hint identity column test

5328079

DavoudEshtehari reviewed Apr 30, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlBulkCopyColumnOrderHintCollectionTest.cs Outdated Show resolved Hide resolved

...icrosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBulkCopyColumnOrderHintCollection.cs Outdated Show resolved Hide resolved

johnnypham requested review from cheenamalhotra, DavoudEshtehari, David-Engel and karinazhou April 30, 2020 22:57

DavoudEshtehari reviewed Apr 30, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/OrderHint.cs Outdated Show resolved Hide resolved

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/SqlBulkCopyTest.cs Outdated Show resolved Hide resolved

cheenamalhotra added this to the 2.0.0 milestone May 4, 2020

karinazhou reviewed May 5, 2020

View reviewed changes

src/Microsoft.Data.SqlClient.sln Outdated Show resolved Hide resolved

johnnypham added 4 commits May 9, 2020 00:09

Collection class reworked to handle duplicate columns

d88cb03

spacing

d7f3deb

Updated tests for duplicate column names, updated documentation

9e737cd

Added couple asserts

4cd38d5

DavoudEshtehari reviewed May 26, 2020

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlBulkCopyColumnOrderHintCollectionTest.cs Outdated Show resolved Hide resolved

johnnypham added 6 commits May 28, 2020 17:26

Addressing comments

9cde0c4

Merge branch 'bulkCopyOrderHints' of https://github.com/johnnypham/Sq…

0093a06

…lClient into bulkCopyOrderHints

Revert "Addressing comments"

2140fd7

This reverts commit 9cde0c4.

Revert "Merge branch 'bulkCopyOrderHints' of https://github.com/johnn…

465fa74

…ypham/SqlClient into bulkCopyOrderHints" This reverts commit 0093a06, reversing changes made to 9cde0c4.

Merge branch 'master' into bulkCopyOrderHints

242b1c3

Addressing comments

ecb43a7