Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow targets override #135

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Allow targets override #135

merged 1 commit into from
Sep 24, 2021

Conversation

BretJohnson
Copy link
Member

Allow a .targets.override file in the parent directory
to customize targets settings for Directory.build.targets.

This is the same change made for androidtools here
https://github.com/xamarin/androidtools/pull/307,
applied to xamarin-android-tools.

Allow a .targets.override file in the parent directory
to customize targets settings for Directory.build.targets.

This is the same change made for androidtools here
xamarin/androidtools#307,
applied to xamarin-android-tools.
@jonpryor
Copy link
Member

…but what properties do you need to override? There's no Git submodules, which was the primary use case in the other submodules.

@jonpryor
Copy link
Member

…but what properties do you need to override?

Not quite a relevant question; this isn't an extension point for Directory.Build.props, it's an extension point for Directory.Build.targets.

See also: https://github.com/xamarin/XamarinVS/pull/12550

@jonpryor jonpryor merged commit 061bcc2 into main Sep 24, 2021
@BretJohnson
Copy link
Member Author

@gitbot backport d17-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants