Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need OS-specific mscorlib.dll/etc. builds #1072

Closed
jonpryor opened this issue Dec 5, 2017 · 2 comments
Closed

Need OS-specific mscorlib.dll/etc. builds #1072

jonpryor opened this issue Dec 5, 2017 · 2 comments
Assignees
@radekdoulik
Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*.
Milestone
d16-1

Comments

@jonpryor
Copy link
Member

jonpryor commented Dec 5, 2017

As part of continuing corefx/etc. code merges into Mono, mscorlib.dll and System.Data.dll (and others?) are going to be OS-specific. As such, we will need to rebuild the BCL for each supported platform (Android, macOS, Windows), instead of using the same binary assemblies on all platforms.
@jonpryor jonpryor added the Area: xamarin-android Build Issues building the xamarin-android repo *itself*. label Dec 5, 2017
@jonpryor
Copy link
Member Author

jonpryor commented Dec 5, 2017

How do we build?

We need to change our configure invocations for each OS to not disable the BCL build.
Then, between each OS build, we need to rename mono/mcs/class/lib/monodroid so that when we rebuild the BCL we don't nuke the previous output.

Mono currently uses deterministic builds, so after building the BCL for all assemblies, we can just diff(1) them to see if they're OS-specific or not. If they're identical, don't copy to the OS-specific install dir (below). If they're unique, copy them.

Install Structure?

xbuild-frameworks/MonoAndroid/v1.0 will continue to be for Android-OS assemblies.

Platform-specific mscorlib.dll/etc. will be placed into xbuild/Xamarin/Android/host-$(OSName), e.g. xbuild/Xamarin/Android/lib/host-Darwin/mscorlib.dll.

Integrations?

We'll need to allow the Android Designer to "know" where the OS-specific files are, so that they're copied in preference to the default Android-OS files.

@jonpryor jonpryor added this to the d15-7 milestone Dec 6, 2017
@jonpryor jonpryor modified the milestones: d15-7, d15-8 Mar 19, 2018
@jonpryor jonpryor modified the milestones: d15-8, d15-9 Apr 30, 2018
@jonpryor jonpryor modified the milestones: d15-9, d16-0 Dec 15, 2018
@dellis1972 dellis1972 modified the milestones: d16-0, d16-1 Jan 28, 2019
@jonpryor
Copy link
Member Author

This was resolved in commit d5e002e.

jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Feb 1, 2020
@jonpryor
Bump to xamarin/monodroid@01a4e0a0
604653e 
Changes: xamarin/monodroid@017b361...01a4e0a

Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1033784
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1035905
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/946984
Context: icsharpcode/SharpZipLib#356

  * xamarin/monodroid@01a4e0a0c: Bump to xamarin/androidtools@2ffbfcb7 (dotnet#1074)
  * xamarin/monodroid@987ce4d1b: Remove external/debugger-libs (dotnet#1072)
  * xamarin/monodroid@7ded15051: Bump to mono/debugger-libs@5e5b5efb (dotnet#1071)
  * xamarin/monodroid@072746460: Bump to xamarin/android-sdk-installer@c694d0da (dotnet#1070)
@jonpryor jonpryor mentioned this issue Feb 1, 2020
Merged
jonpryor added a commit that referenced this issue Feb 1, 2020
@jonpryor
Bump to xamarin/monodroid@01a4e0a0 (#4210)
60b09ee 
Changes: xamarin/monodroid@017b361...01a4e0a

Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1033784
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1035905
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/946984
Context: icsharpcode/SharpZipLib#356

  * xamarin/monodroid@01a4e0a0c: Bump to xamarin/androidtools@2ffbfcb7 (#1074)
  * xamarin/monodroid@987ce4d1b: Remove external/debugger-libs (#1072)
  * xamarin/monodroid@7ded15051: Bump to mono/debugger-libs@5e5b5efb (#1071)
  * xamarin/monodroid@072746460: Bump to xamarin/android-sdk-installer@c694d0da (#1070)
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
Area: xamarin-android Build Issues building the xamarin-android repo *itself*.
Projects
None yet
Milestone
d16-1
Development

No branches or pull requests
3 participants
@jonpryor @dellis1972 @radekdoulik