[linker] Remove C#8 Nullable attributes #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements dotnet#3911 Context: https://github.com/dotnet/roslyn/blob/7bc44488c661fd6bbb6c53f39512a6fe0cc5ef84/docs/features/nullable-metadata.md C#8 non-null reference uses custom attributes to let compiler know more information related to non-null reference. These shouldn't be needed when running on device, as the C# language feature doesn't require modifications to the runtime. Thus it should be safe to remove them.
jonpryor
pushed a commit
that referenced
this pull request
Jan 6, 2020
Fixes: #3911 Context: https://github.com/dotnet/roslyn/blob/7bc44488c661fd6bbb6c53f39512a6fe0cc5ef84/docs/features/nullable-metadata.md C#8 [nullable reference types][0] use custom attributes to inform the compiler about nullability information in the assembly. These custom attributes shouldn't be needed when running on device, as the C# language feature doesn't require modifications to the runtime. Thus it should be safe to remove them. [0]: https://docs.microsoft.com/en-us/dotnet/csharp/nullable-references
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3911
Context: https://github.com/dotnet/roslyn/blob/7bc44488c661fd6bbb6c53f39512a6fe0cc5ef84/docs/features/nullable-metadata.md
C#8 non-null reference uses custom attributes to let compiler know
more information related to non-null reference.
These shouldn't be needed when running on device, as the C# language
feature doesn't require modifications to the runtime. Thus it should
be safe to remove them.