[One .NET] dotnet workload install android or android-aot #6045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
dotnet-workload-install-android
branch
2 times, most recently
from
4e62b46 to
50494a5
Compare
|
I know it's in another manifest, but resumably |
|
@mhutch I can add an |
jonathanpeppers
force-pushed
the
dotnet-workload-install-android
branch
from
50494a5 to
c2ab215
Compare
jonathanpeppers
requested review from
dellis1972,
grendello,
jonpryor and
pjcollins
as code owners
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-macios
that referenced
this pull request
Jun 29, 2021
Context: dotnet/android#6045 We are aiming to simplify the .NET workload ids to short names like: dotnet workload install maui dotnet workload install android dotnet workload install ios dotnet workload install maccatalyst dotnet workload install macos dotnet workload install tvos Updated the workload ids here, as well as the `.stamp-install-workloads` make target. Other changes: * Updated descriptions to match Android. Still waiting on an *official* description we should be using for each workload. * Fixed trailing `,` that showed up as JSON errors in VS Code.
grendello
approved these changes
Jun 29, 2021
dellis1972
reviewed
Jun 29, 2021
src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json
Outdated
Show resolved
Hide resolved
rolfbjarne
pushed a commit
to xamarin/xamarin-macios
that referenced
this pull request
Jun 29, 2021
Context: dotnet/android#6045 We are aiming to simplify the .NET workload ids to short names like: dotnet workload install maui dotnet workload install android dotnet workload install ios dotnet workload install maccatalyst dotnet workload install macos dotnet workload install tvos Updated the workload ids here, as well as the `.stamp-install-workloads` make target. Other changes: * Updated descriptions to match Android. Still waiting on an *official* description we should be using for each workload. * Fixed trailing `,` that showed up as JSON errors in VS Code.
pjcollins
reviewed
Jun 29, 2021
jonathanpeppers
force-pushed
the
dotnet-workload-install-android
branch
3 times, most recently
from
dd3936d to
13ba85b
Compare
jonathanpeppers
changed the title
|
Discussed with @jonpryor and I think the plan is to have two top-level workloads:
So the |
Context: https://github.com/dotnet/maui/tree/ef4518bf502ffa6760625c4cb53fa0cb015bc6d1/src/Workload#net-maui-workload-ids Right now to install the Android workload you would run: dotnet workload install microsoft-android-sdk-full Let's shorten this to be: dotnet workload install android We can also create a new workload that extends `android`, and includes AOT support: dotnet workload install android-aot To test this behavior on our CI, I reworked the `ExtractWorkloadPacks` to run `dotnet workload install` commands. This should give us more confidence that our workload can be installed -- and our MSBuild tests will consume the installed workload. Other changes: * Added our `Microsoft.Android.Runtime.*` packs to the `WorkloadManifest.json`. This was mostly omitted by mistake; however, runtime packs aren't resolved either due to: dotnet/sdk#14044 * Call `setup-test-environment.yaml` in `dotnet_create_msi` job * Delete `dotnet/metadata` folder in `Step_InstallDotNetPreview`
jonathanpeppers
force-pushed
the
dotnet-workload-install-android
branch
from
13ba85b to
6ec79a3
Compare
dellis1972
approved these changes
Jul 6, 2021
Use $(AndroidToolchainDirectory) and random file name as a temporary directory.
jonathanpeppers
force-pushed
the
dotnet-workload-install-android
branch
from
e2d3730 to
54a074a
Compare
jonathanpeppers
force-pushed
the
dotnet-workload-install-android
branch
from
696eaed to
143992b
Compare
pjcollins
approved these changes
Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/dotnet/maui/tree/ef4518bf502ffa6760625c4cb53fa0cb015bc6d1/src/Workload#net-maui-workload-ids
Right now to install the Android workload you would run:
Let's shorten this to be:
We can also create a new workload that extends
android, and includesAOT support:
To test this behavior on our CI, I reworked the
ExtractWorkloadPacksto run
dotnet workload installcommands. This should give us moreconfidence that our workload can be installed -- and our MSBuild tests
will consume the installed workload.
Other changes:
Added our
Microsoft.Android.Runtime.*packs to theWorkloadManifest.json. This was mostly omitted by mistake;however, runtime packs aren't resolved either due to:
Allow runtime packs to be resolved from the packs folder sdk#14044
Call
setup-test-environment.yamlindotnet_create_msijobDelete
dotnet/metadatafolder inStep_InstallDotNetPreview