Attempt to get better logcat logging for failed tests #7816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that more often than not, we don't see the actual error in `logcat-failed.log` when the test fails on CI, but when it runs locally, we can see the issue logged properly. I'm not 100% what causes it on CI, but I suspect that we might be facing a problem with the logcat buffer wrapping around and overwriting the interesting data. This might be because of the fact that `logcat -c` runs only once per **class** containing tests and also because we log too quickly after the app quits. To remedy the former, run `logcat -c` before each test starts and to attempt a fix for the latter, pause for 1 second before dumping logcat buffer after the test fails.
grendello
requested review from
dellis1972 and
jonathanpeppers
as code owners
jonathanpeppers
approved these changes
Feb 21, 2023
dellis1972
reviewed
Feb 21, 2023
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/DeviceTest.cs
Outdated
Show resolved
Hide resolved
* main: [build] Only build the latest API level (dotnet#7786) [Xamarin.Android.Build.Tasks] Improve aapt2+file not found handling (dotnet#7644)
dellis1972
approved these changes
Feb 22, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 23, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820) Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 24, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820) Add Unit Test for testOnly apps (dotnet#7637) [build] Only build the latest API level (dotnet#7786)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 24, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 24, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 24, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 24, 2023
* main: LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822) Localized file check-in by OneLocBuild Task (dotnet#7820)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Feb 27, 2023
* main: Localized file check-in by OneLocBuild (dotnet#7827) Revert "Bump to dotnet/installer@d25a3bb 8.0.100-preview.2.23105.6 (dotnet#7769)" LEGO: Merge pull request 7828 LEGO: Merge pull request 7825 Bump to xamarin/Java.Interop/main@bbaeda6f (dotnet#7799) Bump NDK to r25c (dotnet#7808) [Xamarin.Android.Build.Tests] Improve logcat logging in failed tests (dotnet#7816) [Mono.Android] Update api-compat reference file for current API-33 (dotnet#7822)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that more often than not, we don't see the actual error in
logcat-failed.logwhen the test fails on CI, but when it runs locally,we can see the issue logged properly.
I'm not 100% what causes it on CI, but I suspect that we might be facing
a problem with the logcat buffer wrapping around and overwriting the
interesting data. This might be because of the fact that
logcat -cruns only once per class containing tests and also because we log
too quickly after the app quits.
To remedy the former, run
logcat -cbefore each test starts and toattempt a fix for the latter, pause for 1 second before dumping
logcatbuffer after the test fails.