[build] consider $NUGET_PACKAGES for $(XAPackagesDir) #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://learn.microsoft.com/nuget/reference/cli-reference/cli-ref-environment-variables I recently paved my Windows PC and set `%NUGET_PACKAGES%` to a Dev Drive at: D:\.nuget\packages This caused Xamarin.Android's build to fail with: Mono.Android.targets(220,5): error : CompatApi command: dotnet "C:\Users\jonat\.nuget\packages/microsoft.dotnet.apicompat/7.0.0-beta.22103.1/tools/net472/..\netcoreapp3.1\Microsoft.DotNet.ApiCompat.dll" "D:\src\xamarin-android\tests\api-compatibility\reference\net8.0\Mono.Android.dll" -i "D:\src\xamarin-android\bin\Debug\lib\xamarin.android\xbuild-frameworks\Microsoft.Android\33" --allow-default-interface-methods --baseline "D:\src\xamarin-android\tests\api-compatibility\acceptable-breakages-vReference-net8.0.txt" --validate-baseline --exclude-attributes "D:\src\xamarin-android\tests\api-compatibility\api-compat-exclude-attributes.txt" error : CheckApiCompatibility found nonacceptable Api breakages for ApiLevel: v13.0. error : Could not execute because the specified command or file was not found. error : Possible reasons for this include: error : * You misspelled a built-in dotnet command. error : * You intended to execute a .NET program, but dotnet-C:\Users\jonat\.nuget\packages/microsoft.dotnet.apicompat/7.0.0-beta.22103.1/tools/net472/..\netcoreapp3.1\Microsoft.DotNet.ApiCompat.dll does not exist. error : * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH. I added a check for `$(NUGET_PACKAGES)`. This may not 100% match NuGet behavior, but solves the issue.
dellis1972
approved these changes
Jun 20, 2023
pjcollins
approved these changes
Jun 20, 2023
|
One test phase timed out, but I don't think we need to rerun it. |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jun 21, 2023
* main: [One .NET] fix 'dotnet publish' with no arguments (dotnet#8137) [build] consider `$NUGET_PACKAGES` for `$(XAPackagesDir)` (dotnet#8136) Bump external/xamarin-android-tools from `44885bc` to `3cee10b` (dotnet#8121)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://learn.microsoft.com/nuget/reference/cli-reference/cli-ref-environment-variables
I recently paved my Windows PC and set
%NUGET_PACKAGES%to a Dev Drive at:This caused Xamarin.Android's build to fail with:
I added a check for
$(NUGET_PACKAGES).This may not 100% match NuGet behavior, but solves the issue.