[libzip-windows] use libzip.dll and zlib.dll from NuGet #877
Conversation
When bumping libzip in dotnet#874 or dotnet#863 libzip is no longer building under mxe. We can switch to using the NuGet packages instead.
|
@jonpryor the only thing odd here is this introduces If I look in my current system install on Windows in Was the mxe build somehow getting around not having |
|
|
|
@jonathanpeppers it's possible that your build linked in the static version of |
|
@jonathanpeppers @grendello looking at the install dir on windows we have a |
|
But that might be from something else or a hang over from when we used Ionic. |
|
I think we are going to wait on this PR for now. //TODO: vsix built with xbuild has wrong path, something like |
|
I don’t think we need this anymore. |
Context: dotnet/java-interop#884 Does It Build™? Changes: jonpryor/java.interop@8f7ddcd...77d598d * jonpryor/java.interop@77d598d6: [build] Update more NuGet package versions * jonpryor/java.interop@b37a6478: [build] Bump various NuGets to match related repositories (dotnet#877) * jonpryor/java.interop@1e8f5137: [generator] Remove androidx.annotation from Annotation names (dotnet#882)
Context: dotnet/java-interop#884 Does It Build™? Changes: jonpryor/java.interop@8f7ddcd...27a4bf1 * jonpryor/java.interop@77d598d6: [build] Update more NuGet package versions * jonpryor/java.interop@b37a6478: [build] Bump various NuGets to match related repositories (dotnet#877) * jonpryor/java.interop@1e8f5137: [generator] Remove androidx.annotation from Annotation names (dotnet#882)
Context: dotnet/java-interop#884 Does It Build™? Changes: jonpryor/java.interop@8f7ddcd...659ac71 * jonpryor/java.interop@659ac71c: [build] Update more NuGet package versions * jonpryor/java.interop@3f12cd25: Revert "[generator] Remove androidx.annotation from Annotation names (dotnet#882)" * jonpryor/java.interop@b37a6478: [build] Bump various NuGets to match related repositories (dotnet#877) * jonpryor/java.interop@1e8f5137: [generator] Remove androidx.annotation from Annotation names (dotnet#882)
Changes: dotnet/java-interop@8f7ddcd...c936d09 * dotnet/java-interop@c936d09a: [build] Update more NuGet package versions (dotnet#884) * dotnet/java-interop@3f12cd25: Revert "[generator] Remove androidx.annotation from Annotation names (dotnet#882)" * dotnet/java-interop@b37a6478: [build] Bump various NuGets to match related repositories (dotnet#877) * dotnet/java-interop@1e8f5137: [generator] Remove androidx.annotation from Annotation names (dotnet#882)
Changes: dotnet/java-interop@8f7ddcd...c936d09 * dotnet/java-interop@c936d09a: [build] Update more NuGet package versions (#884) * dotnet/java-interop@3f12cd25: Revert "[generator] Remove androidx.annotation from Annotation names (#882)" * dotnet/java-interop@b37a6478: [build] Bump various NuGets to match related repositories (#877) * dotnet/java-interop@1e8f5137: [generator] Remove androidx.annotation from Annotation names (#882)
When bumping libzip in #874 or #863 libzip is no longer building under
mxe. We can switch to using the NuGet packages instead.