[build] move bundle zip to $(AndroidToolchainCacheDirectory)
#880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the bundle was being downloaded to `bin/BuildDebug`, which would be commonly cleaned for each build on CI systems. We can speed up our builds by downloading the file to `~/android-archives`, which is already used for various other downloads. This will persist the file between builds on the same build agent.
|
@jonathanpeppers, |
jonpryor
approved these changes
Sep 20, 2017
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Sep 21, 2017
Context in dotnet#880 Since we are now downloading the bundle to `~/android-archives`, it is possible that the directory will not exist on a clean machine. We should be calling `Directory.CreateDirectory` in the `DownloadUri` task anyway, as this could easily happen on any destination file. A case this occured happened on VSTS: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1006149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the bundle was being downloaded to
bin/BuildDebug, whichwould be commonly cleaned for each build on CI systems. We can speed up
our builds by downloading the file to
~/android-archives, which isalready used for various other downloads. This will persist the file
between builds on the same build agent.