Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-native tool install testing #663

Merged
merged 11 commits into from
Jul 30, 2019
Merged

Add multi-native tool install testing #663

merged 11 commits into from
Jul 30, 2019

Conversation

jonfortescue
Copy link
Contributor

Will test dotnet/arcade#3400

@jonfortescue jonfortescue requested a review from riarenas July 26, 2019 19:23
@riarenas
Copy link
Member

Failed to download 'https://netcorenativeassets.blob.core.windows.net/resource-packages/external/linux/cmake/cmake-3.11.1jdk:10.0.2-Linux-x86_64.tar.gz

😢

@jonfortescue
Copy link
Contributor Author

AAAAAAAAA

@jonfortescue
Copy link
Contributor Author

@riarenas looking at the build logs more carefully, the windows build should have failed but didn't (it failed to install the jdk). Any ideas?

@riarenas
Copy link
Member

install-tools.ps1 doesn't set any ErrorActionPreference. Maybe that's what's causing it to not fail the build?

@jonfortescue jonfortescue self-assigned this Jul 30, 2019
@jonfortescue jonfortescue merged commit 9b0fb8c into dotnet:master Jul 30, 2019
@jonfortescue jonfortescue deleted the AddMultiNativeToolTesting branch July 30, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riarenas riarenas riarenas approved these changes

Assignees

@jonfortescue jonfortescue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonfortescue @riarenas