Builds failing due to restore failure of recently published packages

[vatsan-madhavan]

I'm seeing builds fail (eg) due to NuGet/Home#3116.

Does the Arcade tools or the Sdk have configuration option to specify --no-cache during restore?
Could this be made the default until this bug is fixed by Nuget?

[vatsan-madhavan]

Just realized that I could do something like this in eng\configure-toolset.ps1:

# Make sure that Nuget restore doesn't hit the cache when running CI builds
# See https://github.com/NuGet/Home/issues/3116
if ($ci) {
    if (($properties -eq $null) -or (-not ($properties -icontains '/p:RestoreNoCache=true'))) {
        $properties = @('/p:RestoreNoCache=true') + $properties
    }
}

Even with this, the results are hit-and-miss.

Given this bug is likely to affect all repos at one time or another, perhaps something like this should be the default anyway?

[tmat]

It'd be simpler to set RestoreNoCache in Directory.Build.props.

Even with this, the results are hit-and-miss.

If restore fails even with this property set then how does it help setting it?

[vatsan-madhavan]

We set it in dotnet-trusted a while back and it helped, and @rrelyea suggests that it is the workaround to the above problem. Perhaps it offers an improvement even if only an imperfect one.

If you can think of a more reliable solution, I’d be happy to adopt it.

[tmat]

If it helps then feel free to send a PR adding

<RestoreNoCache Condition="'$(ContinuousIntegrationBuild)' == 'true'">true</RestoreNoCache> to

https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props#L28