Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if a build is using a package with a bug #2373

Open
Tracked by #2053
JohnTortugo opened this issue Mar 28, 2019 · 4 comments
Open
Tracked by #2053

Warn if a build is using a package with a bug #2373

JohnTortugo opened this issue Mar 28, 2019 · 4 comments
Milestone

Comments

@JohnTortugo
Copy link
Contributor

JohnTortugo commented Mar 28, 2019

I have seen more than once a repo/branch using an old version of Arcade SDK, SignTool, other packages that have bugs that we have already fixed. This have happened for a few reasons: people hardcode versions in Versions.props, we had some values hardcoded in DefaultVersion.props, etc.

I think it would be great if our build system had a way to warn (fail) a build that is trying to use a package that has a known bug.

@chcosta @mmitche @tmat @markwilkie

@markwilkie
Copy link
Member

Maybe put this behind a config of some sort so repo owners can choose to fail or not....

@JohnTortugo
Copy link
Contributor Author

What I think is: using a buggy package might lead to the build failing (best case) or the build succeed but nobody notice that behind the scenes something wrong happened.

@Chrisboh
Copy link
Member

Do we have a way today to identify a package that would be considered buggy and should not be used?

@JohnTortugo
Copy link
Contributor Author

I don't think so. At first I think we could modify BAR to store this information and Maestro API to be able to query it. We could store for instance, PackageName and range of known buggy version. Clients would then use the API check if the package getting restored is within any of the recorded ranges.

@michellemcdaniel michellemcdaniel mentioned this issue Feb 14, 2022
74 tasks
@missymessa missymessa added this to the Arcade SDK milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants