Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Helix telemetry API usage from Arcade Yaml templates #5780

Closed
2 tasks
Tracked by #2053
MattGal opened this issue Jul 13, 2020 · 2 comments
Closed
2 tasks
Tracked by #2053

Remove Helix telemetry API usage from Arcade Yaml templates #5780

MattGal opened this issue Jul 13, 2020 · 2 comments

Comments

@MattGal
Copy link
Member

MattGal commented Jul 13, 2020

  • This issue is blocking
  • This issue is causing unreasonable pain

As part of handling a different issue I noticed these Yamls used the Helix API token to send telemetry:

https://github.com/dotnet/arcade/blob/master/eng/common/templates/steps/telemetry-start.yml
https://github.com/dotnet/arcade/blob/master/eng/common/templates/steps/telemetry-end.yml

Since all they're sending is the build Uri (inaccessible without authenticated access, at which point they can be enumerated just by browsing) I thought we might just remove the auth part (saving a key vault access) but from discussions with @ChadNedzlek we use timeline APIs for this now so fake jobs / work items are no longer desirable from builds.

@alexperovich depending on the outcome of this issue it's likely good to just nerf out but not delete the telemetry endpoints in the API.

@alexperovich
Copy link
Member

The ported version of the api has been changed to not do anything.

@michellemcdaniel michellemcdaniel mentioned this issue Feb 14, 2022
74 tasks
@missymessa
Copy link
Member

These were removed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants