Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Arcade's Helix builds use VSTest #6858

Open
2 tasks
Tracked by #2053
chcosta opened this issue Jan 26, 2021 · 0 comments
Open
2 tasks
Tracked by #2053

Make Arcade's Helix builds use VSTest #6858

chcosta opened this issue Jan 26, 2021 · 0 comments
Milestone

Comments

@chcosta
Copy link
Member

chcosta commented Jan 26, 2021

  • This issue is blocking
  • This issue is causing unreasonable pain

The way Arcade's builds send jobs to Helix was written using XUnit. XUnit lacks some of the flexibility that VSTests supports. In writing tests for SignCheck, I needed to update ARcade to spin up an entirely separate Helix queue just for the SignCheck tests. I also had to wire through utilizing the x86 console runner. I wrote the code to do this, but it's a lot of extra code, and not well vetted, yet.

#6800 (comment)

We could, either spend time reviewing those changes and testing this new feature of using the XUnit runner, or we could invest in #4539. My preference is the latter, but I'm not sure where that is on the priority list and if it's worth waiting on that before we add tests for SignCheck. On the flip side, we haven't had any SignCheck unit tests up to this point, so it's hard to build a case on that data point and I'm unsure what to do with the SignCheck PR in the interim..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants