Do not fail backport if commenting fails #11637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to backport and old PR where github already locked conversation, the commenting will fail. It's an odd reason to fail backport.
|
While this would work the bot would still not be able to comment when failures/conflicts happen later on. I wonder if we should instead try to unlock the issue as a first step (it should be a no-op afaik if the issue is already open). I'll try whether the GH Actions has enough permissions to do that. |
|
Looks like it was even easier since we have access to the event payload that tells us whether a PR is locked. See #11639 |
|
closing in favor of #11639. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to backport an old PR where github already locked the conversation, the commenting step will fail. It's an odd reason to fail backport.
Example of a failed backport: https://github.com/dotnet/runtime/actions/runs/3468792216