Remove NuGet.Packaging.Core usage from arcade, use NuGet.Packaging instead #12907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
commented
Mar 17, 2023
| @@ -33,18 +33,19 @@ public override SignatureVerificationResult VerifySignature(string path, string | |||
|
|
|||
| private bool IsSigned(string path) | |||
| { | |||
| IEnumerable<ISignatureVerificationProvider> providers = SignatureVerificationProviderFactory.GetSignatureVerificationProviders(); | |||
There was a problem hiding this comment.
This is the only change that actually changes behavior.
I'm unsure if this is still being used, but unlikely that this is related to the problems the .NET SDK encountered, since a lot of the types have changed. Example: SignatureVerificationProviderFactory does not exist in 4.9.
I'd be happy to revert this change if you prefer to minimize the risk.
There was a problem hiding this comment.
cc @dtivel
Can you please take a look at this change?
The project is .NET Framework and likely only runs on windows.
There was a problem hiding this comment.
This does run, but only on Windows and .NET Framework.
dtivel
approved these changes
Mar 17, 2023
mmitche
approved these changes
Mar 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12906
To double check: