Do not generate symbol packages in outer source-build #13931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it's possible for a build to contain a set of assets with duplicated names. This can occur in various places: - Merged manifest contains dupes - Maestro build asset list contains dupes These may not be exact dupes. You could have two assets with the same name but different versions. However, I think this scenario should generally be disallowed. A Maestro build with multiple assets with the same name would not be able to successfully flow dependencies downstream. What is chosen to flow downstream would essentially be arbitrary, which is not desirable. So, I think we should take steps to disallow this scenario and harden against it. Fully hardening against it will require changes at multiple levels: - Manifest merging (disallow duplicate entries even with same name + version) - Maestro build asset upload - Arcade publishing. It's important to harden in multiple locations to improve error handling and avoid missing some code paths (e.g. if the merging code was updated in some branches but not others). This PR begins this process by hardening the publishing phase. In addition, some general code cleanup and refactoring was performed.
The source build intermediates simply contain nupkgs, no symbols. Generating these packages just creates a copy of the original package.
|
@mmitche is this going to prevent generation of various |
It may be that I want to avoid setting this in the inner build. Either way, this only prevents a file copy from Foo.nupkg to Foo.symbols.nupkg. In this case, the source build intermediates are just being copied over to a symbols nupkg but with identical content (a bunch of nupkgs). |
NikolaMilosavljevic
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check: