Fix ResourceUsageAnalyzer to account for new overloads #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This analyzer is trying to prevent calls to SR.Format(SR.Something), which should just be simplified to SR.Something. I'm adding some new SR overloads to also support culture, and the way the analyzer is currently coded causes it to fire incorrectly. This just simplifies the analyzer, eliminating the false positives.
tarekgh
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This analyzer is trying to prevent calls to SR.Format(SR.Something), which should just be simplified to SR.Something. But it's buggy and isn't doing so. Also, I'm adding some new SR overloads to also support culture, and the way the analyzer is currently coded causes it to fire incorrectly. This just simplifies the analyzer, eliminating the false positives.
cc: @tarekgh
Contributes to https://github.com/dotnet/corefx/issues/35001