Allow 'IsWpfTempProject' to be set to prevent duplicate imports when restoring packages in temporary projects #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e imports when adding PackageReference restore to WPF for .NET Core temporary projects.
|
Please be sure there's a tracking issue to follow up after the next WPF preview release. |
rladuca
reviewed
Jun 21, 2019
|
@markwilkie, I've opened this issue to track the removal: #3129. Thanks. |
There was a problem hiding this comment.
lgtm - please reduce the condition footprint per @rladuca’s suggestion.
rladuca
reviewed
Jun 21, 2019
rladuca
approved these changes
Jun 21, 2019
tmat
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPF for .NET Core is adding a restore step to temporary project compilation for PackageReferences. The existing Arcade workaround needs to be temporarily updated to prevent duplicate imports, then removed entirely after the next WPF Preview release.