Chosing the target repo for a mirrored commit on the basis of branch and sourceRepo #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
reviewed
Jul 26, 2019
| @@ -25,9 +25,9 @@ namespace Microsoft.DotNet.GitSync | |||
| internal class Program | |||
| { | |||
| private const string TableName = "CommitHistory"; | |||
| private const string RepoTableName = "MirrorRepos"; | |||
| private const string RepoTableName = "MirrorBranchRepos"; | |||
There was a problem hiding this comment.
It feels like this s_repos dictionary logic can be shared in between these two guys.
There was a problem hiding this comment.
i can try to do it in a separate PR
safern
approved these changes
Jul 26, 2019
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3403
cc @danmosemsft @safern