Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run _GenerateResxSource target before BeforeCompile target. #4062

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Run _GenerateResxSource target before BeforeCompile target. #4062

merged 1 commit into from
Oct 5, 2019

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 4, 2019

The Common.targets convention is to hook code-generation targets to BeforeCompile.
Fixes dotnet/sourcelink#392

@tmat
Run _GenerateResxSource target before BeforeCompile target.
43084c2 
The Common.targets convention is to hook code-generation targets to BeforeCompile.
Fixes dotnet/sourcelink#392
@tmat tmat mentioned this pull request Oct 4, 2019
Closed
@tmat
Copy link
Member Author

tmat commented Oct 4, 2019

@hoyosjs @chcosta PTAL

@tmat
Copy link
Member Author

tmat commented Oct 4, 2019

@hoyosjs Could you please follow up with revert of dotnet/coreclr#26394 once this change gets propagated to coreclr?

hoyosjs
hoyosjs approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look to see what's the first Arcade package with this bits that we can uptake in CoreClr. Thanks for the fix!

@tmat
Copy link
Member Author

tmat commented Oct 4, 2019 •
edited
Loading

@hoyosjs I think we should also set EmbedUntrackedSources to true by default in Arcade SDK. All repos will need it in order to pass SourceLink validation.

@hoyosjs
Copy link
Member

hoyosjs commented Oct 5, 2019

@hoyosjs I think we should also set EmbedUntrackedSources to true by default in Arcade SDK. All repos will need it in order to pass SourceLink validation.

In general, I agree. It's good that even build-time generated artifacts are diagnosable. CoreClr generates some for eventing, but for example arcade itself will always generate some for file metadata and resources. I created #4064, let me know if that's the right place.

@tmat
Copy link
Member Author

tmat commented Oct 5, 2019

Realized we will also need to push the latest Source Link package to Arcade - need to add DependsOnTargets there to guarantee ordering.

@tmat tmat merged commit 1cd8bed into dotnet:master Oct 5, 2019
@tmat tmat deleted the FixGenerateResxSource branch October 5, 2019 01:06
rladuca added a commit to rladuca/wpf that referenced this pull request Oct 16, 2019
@rladuca
Adding workaround for dotnet/arcade#4062
b361642
rladuca added a commit to rladuca/wpf that referenced this pull request Oct 16, 2019
@rladuca
Removing workaround for dotnet/arcade#4062 as a fix has been affected…
fa58f2d 
… in Arcade
dotnet-maestro bot added a commit to dotnet/wpf that referenced this pull request Oct 18, 2019
@dotnet-maestro
[master] Update dependencies from dotnet/arcade (#2050)
fb5c338 
* Update dependencies from https://github.com/dotnet/arcade build 20191015.1

- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19515.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19515.1
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19515.1
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19515.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19515.1

* Fix configure-toolset.ps1 to ensure the existence of the properties variable.

* Fixing scope and adding comment

* Update dependencies from https://github.com/dotnet/arcade build 20191015.2

- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19515.2
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19515.2
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19515.2
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19515.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19515.2

* Adding workaround for dotnet/arcade#4062

* Removing workaround for dotnet/arcade#4062 as a fix has been affected in Arcade

* Update dependencies from https://github.com/dotnet/arcade build 20191017.7

- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19517.7
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19517.7
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19517.7
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19517.7
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19517.7
tmat added a commit to tmat/arcade that referenced this pull request Apr 16, 2020
@tmat
Run _GenerateResxSource target before BeforeCompile target. (dotnet#4062
666f928 
)

The Common.targets convention is to hook code-generation targets to BeforeCompile.
Fixes dotnet/sourcelink#392
@tmat tmat mentioned this pull request Apr 16, 2020
Merged
tmat added a commit that referenced this pull request Apr 17, 2020
@tmat
Run _GenerateResxSource target before BeforeCompile target. (#5276)
c1fb22a 
* Run _GenerateResxSource target before BeforeCompile target. (#4062)

The Common.targets convention is to hook code-generation targets to BeforeCompile.
Fixes dotnet/sourcelink#392

* Change BeforeTargets of _GenerateResxSource to BeforeCompile;CoreCompile (#4134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated resource files are not included by EmbedUntrackedSources
2 participants
@tmat @hoyosjs