Set EmbedUntrackedSources=false to prevent generated WPF files from being gathered during SourceLink #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets gethers these files for embedding in _SetEmbeddedFilesFromSourceControlManagerUntrackedFiles otherwise
|
Note: We found this by investigating the following failure: https://github.com/dotnet/wpf/pull/2051/checks?check_run_id=261380012 |
|
You meant to write |
🤦♂ |
vatsan-madhavan
changed the title
tmat
approved these changes
Oct 16, 2019
|
@vatsan-madhavan This workaround is masking a product bug. The root cause is dotnet/wpf#1718 - WPF generates incorrect relative paths in |
|
You’re right. dotnet/wpf#1718 may not be addressed before .NET 5, so this workaround is a good thing to have for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set EmbedUntrackedSources=false in Workarounds.props since Microsoft.SourceLink.Common.targets gathers these files for embedding in _SetEmbeddedFilesFromSourceControlManagerUntrackedFiles otherwise
/cc @rladuca
/cc @chcosta, @tmat