Allow filtering by resource state and health status, and update the filters based on visible grid items #6925
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,45 @@ | ||||||
| @using System.Collections.Concurrent | ||||||
|
|
||||||
| @inject IStringLocalizer<Dashboard.Resources.Resources> Loc | ||||||
|
|
||||||
| <FluentStack Orientation="Orientation.Vertical" VerticalGap="15"> | ||||||
| <div> | ||||||
| <h4>@Loc[nameof(Resources.Resources.ResourcesResourceTypesHeader)]</h4> | ||||||
| <SelectResourceOptions | ||||||
| AllValues="AllResourceTypes" | ||||||
| OnAllResourceTypesCheckedChangedAsync="OnAllFilterVisibilityCheckedChangedAsync" | ||||||
| OnValueVisibilityChangedAsync="OnResourceFilterVisibilityChangedAsync"/> | ||||||
| </div> | ||||||
| <div> | ||||||
| <h4>@Loc[nameof(Resources.Resources.ResourcesResourceStatesHeader)]</h4> | ||||||
| <SelectResourceOptions | ||||||
| AllValues="AllResourceStates" | ||||||
| OnAllResourceTypesCheckedChangedAsync="OnAllFilterVisibilityCheckedChangedAsync" | ||||||
| OnValueVisibilityChangedAsync="OnResourceFilterVisibilityChangedAsync"/> | ||||||
| </div> | ||||||
| <div> | ||||||
| <h4>@Loc[nameof(Resources.Resources.ResourcesDetailsHealthStateProperty)]</h4> | ||||||
| <SelectResourceOptions | ||||||
| AllValues="AllResourceHealthStates" | ||||||
| OnAllResourceTypesCheckedChangedAsync="OnAllFilterVisibilityCheckedChangedAsync" | ||||||
| OnValueVisibilityChangedAsync="OnResourceFilterVisibilityChangedAsync"/> | ||||||
| </div> | ||||||
| </FluentStack> | ||||||
|
|
||||||
| @code { | ||||||
|
|
||||||
| [Parameter, EditorRequired] | ||||||
| public required ConcurrentDictionary<string, bool> AllResourceTypes { get; set; } | ||||||
|
There was a problem hiding this comment.
Suggested change
Same for the rest |
||||||
|
|
||||||
| [Parameter, EditorRequired] | ||||||
| public required ConcurrentDictionary<string, bool> AllResourceStates { get; set; } | ||||||
|
|
||||||
| [Parameter, EditorRequired] | ||||||
| public required ConcurrentDictionary<string, bool> AllResourceHealthStates { get; set; } | ||||||
|
|
||||||
| [Parameter, EditorRequired] | ||||||
| public required Func<Task> OnAllFilterVisibilityCheckedChangedAsync { get; set; } | ||||||
|
|
||||||
| [Parameter, EditorRequired] | ||||||
| public required Func<string, bool, Task> OnResourceFilterVisibilityChangedAsync { get; set; } | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,39 @@ | ||||||
| @namespace Aspire.Dashboard.Components | ||||||
|
|
||||||
| @using System.Collections.Concurrent | ||||||
| @using Aspire.Dashboard.Resources | ||||||
|
|
||||||
| @inject IStringLocalizer<ControlsStrings> ControlsStringsLoc | ||||||
|
|
||||||
| @typeparam TValue where TValue : notnull | ||||||
|
|
||||||
| <FluentStack Orientation="Orientation.Vertical"> | ||||||
| <FluentCheckbox Label="@ControlsStringsLoc[nameof(ControlsStrings.LabelAll)]" | ||||||
| ThreeState="true" | ||||||
| ShowIndeterminate="false" | ||||||
| ThreeStateOrderUncheckToIntermediate="true" | ||||||
| @bind-CheckState:get="@GetCheckState(AllValues)" | ||||||
| @bind-CheckState:set="@OnAllValuesCheckedChangedInternalAsync" | ||||||
| /> | ||||||
|
|
||||||
| @foreach (var (resourceType, isChecked) in AllValues.OrderBy(pair => pair.Key.ToString(), StringComparer.OrdinalIgnoreCase)) | ||||||
| { | ||||||
| <FluentCheckbox Label="@(resourceType.ToString())" | ||||||
| @bind-Value:get="@isChecked" | ||||||
| @bind-Value:set="@(c => OnValueVisibilityChangedInternalAsync(resourceType, c))" /> | ||||||
| } | ||||||
| </FluentStack> | ||||||
|
|
||||||
| @code { | ||||||
| [Parameter, EditorRequired] | ||||||
| public required ConcurrentDictionary<TValue, bool> AllValues { get; set; } | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| [Parameter] | ||||||
| public EventCallback<bool?> AreAllVisibleChanged { get; set; } | ||||||
|
|
||||||
| [Parameter, EditorRequired] | ||||||
| public required Func<Task> OnAllResourceTypesCheckedChangedAsync { get; set; } | ||||||
|
|
||||||
| [Parameter, EditorRequired] | ||||||
| public required Func<TValue, bool, Task> OnValueVisibilityChangedAsync { get; set; } | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,71 @@ | ||||||||||||||||||||||
| // Licensed to the .NET Foundation under one or more agreements. | ||||||||||||||||||||||
| // The .NET Foundation licenses this file to you under the MIT license. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| using System.Collections.Concurrent; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| namespace Aspire.Dashboard.Components; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| public partial class SelectResourceOptions<TValue> | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| private async Task OnAllValuesCheckedChangedInternalAsync(bool? newAreAllVisible) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| SetCheckState(newAreAllVisible, AllValues); | ||||||||||||||||||||||
| await OnAllResourceTypesCheckedChangedAsync(); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
Comment on lines
+10
to
+14
There was a problem hiding this comment.
Suggested change
Don't need |
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| private async Task OnValueVisibilityChangedInternalAsync(TValue value, bool isVisible) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| if (isVisible) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| AllValues[value] = true; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| else | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| AllValues[value] = false; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
Comment on lines
+18
to
+25
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| await OnValueVisibilityChangedAsync(value, isVisible); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| private static void SetCheckState(bool? newAreAllVisible, ConcurrentDictionary<TValue, bool> values) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| if (newAreAllVisible is null) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| return; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| foreach (var key in values.Keys) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| values[key] = newAreAllVisible.Value; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| private static bool? GetCheckState(ConcurrentDictionary<TValue, bool> values) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| if (values.IsEmpty) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| return true; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| var areAllChecked = true; | ||||||||||||||||||||||
| var areAllUnchecked = true; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| foreach (var value in values.Values) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| if (value) | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| areAllUnchecked = false; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| else | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| areAllChecked = false; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| return areAllChecked | ||||||||||||||||||||||
| ? true | ||||||||||||||||||||||
| : areAllUnchecked | ||||||||||||||||||||||
| ? false | ||||||||||||||||||||||
| : null; | ||||||||||||||||||||||
|
Comment on lines
+65
to
+69
There was a problem hiding this comment. I don't like nested ternary statements. Make at least one of these an if. There was a problem hiding this comment. You can flatten them or use switch expressions 😄 |
||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Titles feel too big. Make them h5.