Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service defaults to enable metric exemplars #7155

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

matthebrown
Copy link
Contributor

@matthebrown matthebrown commented Jan 19, 2025

Description

Updates Aspire service defaults to enable metric examplars.

Fixes #4839

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 19, 2025
@JamesNK
Copy link
Member

JamesNK commented Jan 19, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Member

JamesNK commented Jan 20, 2025

Thanks!

@JamesNK JamesNK merged commit f5f3395 into dotnet:main Jan 20, 2025
9 checks passed
@matthebrown matthebrown deleted the EnableMetricExemplars branch January 20, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update templates' service defaults to enable metric exemplars
2 participants