Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignOutAsync should take [] of AuthenticationSchemes #2721

Closed
aspnet-hello opened this issue Jan 2, 2018 · 4 comments
Closed

SignOutAsync should take [] of AuthenticationSchemes #2721

aspnet-hello opened this issue Jan 2, 2018 · 4 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-http-abstractions
Milestone

Comments

@aspnet-hello
Copy link

From @Tratcher on Monday, March 14, 2016 3:28:57 PM

From @rustd on March 14, 2016 22:22

A user has to specify SignOut per authentication scheme as follows https://github.com/aspnet/Templates/blob/dev/src/Rules/StarterWeb/OrganizationalAuth/Single/Controllers/AccountController.cs#L24
With this change we will have the same code as in Katana

Copied from original issue: aspnet/Security#742

Copied from original issue: aspnet/HttpAbstractions#585

@aspnet-hello
Copy link
Author

From @Tratcher on Monday, March 14, 2016 3:31:32 PM

I don't think we need this, we had considered it as an intermediate design that didn't provide AuthProperties but opted for aspnet/Security#743 instead.

@aspnet-hello
Copy link
Author

From @PinpointTownes on Monday, March 14, 2016 6:03:24 PM

The syntax in MVC would be much better if aspnet/Mvc#4259 was merged.

/cc @danroth27

@aspnet-hello
Copy link
Author

From @Tratcher on Saturday, July 8, 2017 9:14:53 PM

@HaoK is this still relevant or can we close it? It looks like MVC is doing most of the work for us.

@HaoK
Copy link
Member

HaoK commented Jan 16, 2018

Yeah we can close, MVC has a SignOut result that takes a list of schemes. Its not very common to sign out multiple schemes at once anyways...

@HaoK HaoK closed this as completed Jan 16, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-http-abstractions
Projects
None yet
Development

No branches or pull requests

4 participants