Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reliance on preview LanguageVersion for incremental RSG #33848

Closed
captainsafia opened this issue Jun 25, 2021 · 5 comments
Closed

Remove reliance on preview LanguageVersion for incremental RSG #33848

captainsafia opened this issue Jun 25, 2021 · 5 comments
Labels
Milestone

Comments

@captainsafia
Copy link
Member

The incremental RSG currently requires a preview language version. We'll need to remove this once the compiler supports it.

@ghost
Copy link

ghost commented Jun 25, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@pranavkm
Copy link
Contributor

Resolved as part of dotnet/sdk#18817

@captainsafia
Copy link
Member Author

@pranavkm Actually no. I had to revert because the incremental API still depends on the preview version. Confirmed the behavior with Chris last week.

@captainsafia captainsafia reopened this Jul 15, 2021
@pranavkm pranavkm removed this from the 6.0-rc1 milestone Jul 15, 2021
@pranavkm
Copy link
Contributor

Clearing the milestone so we can bring this up for triage. We want to fix this for rc1.

@mkArtakMSFT
Copy link
Member

@pranavkm what is left here given that your PRs were already merged in the SDK repo?

@pranavkm pranavkm closed this as completed Sep 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2021
chsienki pushed a commit to chsienki/razor-compiler that referenced this issue May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants