Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name for EventId in logs #6381

Closed
34 tasks done
Kahbazi opened this issue Jan 4, 2019 · 8 comments
Closed
34 tasks done

Add name for EventId in logs #6381

Kahbazi opened this issue Jan 4, 2019 · 8 comments
Assignees
@HaoK
Labels
affected-most This issue impacts most of the customers area-dataprotection Includes: DataProtection area-hosting Includes Hosting area-identity Includes: Identity and providers area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one good first issue Good for newcomers. ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! help wanted Up for grabs. We would accept a PR to help resolve this issue severity-major This label is used by an internal tool
Milestone
6.0-preview2

Comments

@Kahbazi
Copy link
Member

Kahbazi commented Jan 4, 2019 •
edited by HaoK
Loading

Can we have log event name for logs in all the projects? Lately it has been added for MVC (aspnet/Mvc#6818)

I can submit a PR if it's ok.

Here's a list of projects so we can see which one already has the event name and which one doesn't.

  • Microsoft.AspNetCore.DataProtection
  • Microsoft.AspNetCore.Hosting
  • Microsoft.AspNetCore.Identity
  • Microsoft.AspNetCore.Server.HttpSys
  • Microsoft.Extensions.Identity.Core
  • Microsoft.AspNetCore.Server.Kestrel.Core
  • Microsoft.AspNetCore.HostFiltering
  • Microsoft.AspNetCore.Antiforgery
  • Microsoft.AspNetCore.Routing
  • Microsoft.AspNetCore.Cors
  • Microsoft.AspNetCore.Diagnostics
  • Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore
  • Microsoft.AspNetCore.Localization
  • Microsoft.AspNetCore.HttpsPolicy
  • Microsoft.AspNetCore.ResponseCaching
  • Microsoft.AspNetCore.ResponseCompression
  • Microsoft.AspNetCore.Rewrite
  • Microsoft.AspNetCore.Session
  • Microsoft.AspNetCore.StaticFiles
  • Microsoft.AspNetCore.Mvc.Core
  • Microsoft.AspNetCore.Mvc.Formatters.Json
  • Microsoft.AspNetCore.Authentication
  • Microsoft.AspNetCore.Authentication.Cookies
  • Microsoft.AspNetCore.Authentication.JwtBearer
  • Microsoft.AspNetCore.Authentication.OpenIdConnect
  • Microsoft.AspNetCore.Authentication.Twitter
  • Microsoft.AspNetCore.Authentication.WsFederation
  • Microsoft.AspNetCore.Authorization
  • Microsoft.AspNetCore.CookiePolicy
  • Microsoft.AspNetCore.Http.Connections
  • Microsoft.AspNetCore.Http.Connections.Client
  • Microsoft.AspNetCore.SignalR.Client.Core
  • Microsoft.AspNetCore.SignalR.Core
  • Microsoft.AspNetCore.SignalR.StackExchangeRedis
@blowdart
Copy link
Contributor

blowdart commented Jan 4, 2019

Speaking for the Authentication, Authorization and DataProtection pieces I'd be happy to look at a PR for those

Kahbazi added a commit to Kahbazi/AspNetCore that referenced this issue Jan 5, 2019
@Kahbazi
Add log event name for security projects (dotnet#6381)
69142dc
@Kahbazi Kahbazi mentioned this issue Jan 5, 2019
Merged
@JamesNK
Copy link
Member

JamesNK commented Jan 7, 2019 •
edited
Loading

I'll do Microsoft.AspNetCore.Routing & StaticFiles

This was referenced Jan 7, 2019
Merged
Merged
@Kahbazi Kahbazi mentioned this issue Jan 7, 2019
Merged
@Kahbazi
Copy link
Member Author

Kahbazi commented Jan 7, 2019

I'll take projects in Middleware.sln

This was referenced Jan 8, 2019
Merged
Merged
@Kahbazi
Copy link
Member Author

Kahbazi commented Jan 9, 2019

There's no LoggingExtensions class in Microsoft.AspNetCore.Identity and Microsoft.Extensions.Identity.Core. Should I add one while adding event names?

https://github.com/aspnet/AspNetCore/blob/master/src/Identity/Extensions.Core/src/UserManager.cs#L711

@analogrelay analogrelay added area-dataprotection Includes: DataProtection area-hosting area-identity Includes: Identity and providers good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue labels Jun 10, 2019
@analogrelay analogrelay added this to the Backlog milestone Jun 10, 2019
@mikeo52 mikeo52 mentioned this issue Jun 19, 2019
Merged
@nblumhardt nblumhardt mentioned this issue Aug 20, 2019
Merged
@RozzaysRed RozzaysRed mentioned this issue Oct 9, 2019
Closed
@Tratcher
Copy link
Member

Tratcher commented Nov 4, 2019

There's no LoggingExtensions class in Microsoft.AspNetCore.Identity and Microsoft.Extensions.Identity.Core. Should I add one while adding event names?

https://github.com/aspnet/AspNetCore/blob/master/src/Identity/Extensions.Core/src/UserManager.cs#L711

At least add a central list of event ids like Hosting.
https://github.com/aspnet/AspNetCore/pull/11379/files#diff-db6cb8ff7c72fa42502138fd3aab3a85

@Kahbazi
Copy link
Member Author

Kahbazi commented Nov 4, 2019

@Tratcher ok, I'll work on Microsoft.AspNetCore.Identity.

This was referenced Nov 6, 2019
Merged
Merged
@kuns200
Copy link
Contributor

kuns200 commented Jan 22, 2020

I am planning to take Microsoft.AspNetCore.Server.HttpSys

@kuns200 kuns200 mentioned this issue Jan 24, 2020
Merged
@mkArtakMSFT mkArtakMSFT added affected-most This issue impacts most of the customers enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Nov 6, 2020 — with ASP.NET Core Issue Ranking
@mkArtakMSFT mkArtakMSFT added the severity-major This label is used by an internal tool label Nov 6, 2020 — with ASP.NET Core Issue Ranking
@blowdart blowdart modified the milestones: Backlog, 6.0-preview2 Jan 25, 2021
@HaoK HaoK self-assigned this Jan 25, 2021
@HaoK
Copy link
Member

HaoK commented Jan 26, 2021

Looks like that's everything checked off now, thanks to everyone who helped for getting this done!

@HaoK HaoK added ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! Done This issue has been fixed labels Jan 26, 2021
@HaoK HaoK closed this as completed Jan 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
@amcasey amcasey added area-hosting Includes Hosting area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
affected-most This issue impacts most of the customers area-dataprotection Includes: DataProtection area-hosting Includes Hosting area-identity Includes: Identity and providers area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one good first issue Good for newcomers. ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! help wanted Up for grabs. We would accept a PR to help resolve this issue severity-major This label is used by an internal tool
Projects
None yet
Milestone
6.0-preview2
Development

No branches or pull requests
9 participants
@analogrelay @JamesNK @blowdart @Tratcher @HaoK @amcasey @Kahbazi @kuns200 @mkArtakMSFT