Increase stack size for host when running in IIS In-Proc

[analogrelay]

Epic #8833

Blocked by https://github.com/dotnet/coreclr/issues/21450

Once there's an API/Property to increase the stack size, we need to react to it in IIS in two ways:

1. Increase the default to something more appropriate for our scenario
2. Make it configurable in web.config (if possible).

[analogrelay]

ETA of the blocking issue is preview6.

[jahanford]

@anurse can the stack size limits cause issues with the inbuilt Dependency Injection or am I more likely having a dependency recursion problem? I'm having an overflow exception only present when using InProcess hosting.

[analogrelay]

I'm not specifically aware of DI issues here, but it is certainly possible. The stack size when running in IIS is significantly smaller than when running as a standard .NET Console app. The easiest way to test is to run your app directly on Kestrel and see if you still hit the StackOverflowException. If you do, it's more likely to be a runaway recursive call, if you don't it may just be a deep stack that's hitting the IIS limit.

[jahanford]

@anurse thank you for the timely response, I have no issues when running on Kestrel, hopefully this change in 3.0 fixes it up.

[analogrelay]

Good to know! Yeah, that indicates you should have a better experience when we get this change in.

[analogrelay]

Need to review if the corefx API is present.

[martincostello]

@Projkt-James We seemed to experience the issue with 2.2.x when doing model binding, particularly when re-executing a request in an error handler.

[analogrelay]

Yep, I believe model binding can also produce fairly deep stacks. This should be improved with this coming change.

[jkotalik]

dotnet/core-setup#5859 should be merge into our repo soon, so we can work on this.

[analogrelay]

Still blocked on https://github.com/dotnet/coreclr/issues/21450

[analogrelay]

CoreCLR builds starting with dotnet/coreclr@6a85ca5 now support the COMPlus_DefaultStackSize environment variable for configuring the default stack size in bytes (see dotnet/coreclr#24532).

There is also a runtime property DEFAULT_STACK_SIZE, but configuring that in ANCM is blocked at the moment (#9520)

[analogrelay]

Apparently we're behind on deps here, waiting on a new coreclr. BAR says we're 7 days old from coreclr and the commit referenced above is 7 days old.

[jkotalik]

Acceptance checklist (check one item)

• We decided not to take this fix.
• The fix is tests-only.
• The fix contains product changes (check all items below).
  • Relevant XML documentation comments for new public APIs are present.
  • Narrative docs (docs.microsoft.com) are updated. (check one item below)
    • The change requires a new article. An issue with an outline has been filed here: [ISSUE LINK]
    • The change requires a change to an existing article. A closed docs PR with these changes is linked here: Doc stack size limit AspNetCore.Docs#12590 (note, PR is still open)
    • The change requires no docs changes.
  • Verification has been completed. (check one item below)
    • The change is in the shared framework and was verified against the following versions
      • SDK installer: 3.0.100-preview6-012113
      • ASP.NET Core Runtime: 3.0.0-preview6-19279-01
      • .NET Core Runtime: 3.0.0-preview6-27728-04
    • The change is in an OOB NuGet/NPM/JAR package and was verified against the following version of that package: [PACKAGE ID] [VERSION]