-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use runtime property settings instead of environment variables for setting startup hook #9520
Comments
Blocked on dotnet/core-setup#5859 |
This is now available in hostfxr 3.0.0-preview6-27707-04, when that lands in our repo (in the next day or so). Reminder (to myself) to check if it's arrived in the triage tomorrow
|
Looks like it's in our repo now:
|
This change will actually be a lot larger than I expected. It requires a whole new set of hostfxr apis to be used, and may expand into more issues. Defensively putting cost M on it. |
Blocked on https://github.com/dotnet/core-setup/issues/6388 now. |
Acceptance checklist (check one item)
|
Epic #8833
The startup hook today is set via environment variable right now (https://github.com/aspnet/AspNetCore/blob/master/src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessapplication.cpp#L241). Core-setup will eventually be adding an api to set runtime properties like https://github.com/dotnet/core-setup/pull/5336/files#diff-15fec1485f5f10c590d5b840300283ceR233. We should use these instead.
The text was updated successfully, but these errors were encountered: