Add clean.ps1 and clean.sh #11154
Merged
Add clean.ps1 and clean.sh #11154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dougbu
commented
Jun 12, 2019
dougbu
commented
- Add a clean.cmd command #10463
clean.sh
Outdated
|
|
||
| # This incantation avoids unbound variable issues if git_args is empty | ||
| # https://stackoverflow.com/questions/7577052/bash-empty-array-expansion-with-set-u | ||
| git clean -dix -e .dotnet/ -e .tools/ -e src/SignalR/clients/ts/FunctionalTests/node_modules/ ${git_args[@]+"${git_args[@]}"} |
There was a problem hiding this comment.
Suggested change
| git clean -dix -e .dotnet/ -e .tools/ -e src/SignalR/clients/ts/FunctionalTests/node_modules/ ${git_args[@]+"${git_args[@]}"} | |
| git clean -dix -e .dotnet/ -e .tools/ ${git_args[@]+"${git_args[@]}"} |
Git on non-Windows handles symlinks correctly, so we don't need this exclusion :)
natemcmaster
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Seems fine to me. Would be good to get @Tratcher's approval -- he was one of the devs requesting this.
|
That looks helpful. How about cmd? We have cmd for most other common commands. |
analogrelay
added
the
area-infrastructure
|
Took your suggestion @Tratcher |
Tratcher
approved these changes
Jun 12, 2019
|
Another now-standard timeout of the build. Merging since issue can't be related to these three new files. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.