Remove dotnet-format from dotnet-tools

[Tratcher]

Restore.cmd is failing because it can't find this tool on our feeds. The version it's looking for isn't even on nuget.org. https://www.nuget.org/packages/dotnet-format/

We're not using this tool right now so I'm removing it.

[dougbu]

This is fine to remove because @SteveSandersonMS removed the pre-commit hook using dotnet-format.

Need for this cleanup is a bit odd however. The package must exist somewhere or our CI builds would have failed. I see Tool 'dotnet-format' (version '5.0.210401') was restored. Available commands: dotnet-format at https://dev.azure.com/dnceng/public/_build/results?buildId=1003771&view=logs&j=efda9e5f-cf98-536e-4181-9b6c13ac35b3&t=de5280bb-c511-517b-1959-798dcf9a84da&l=50 for example. (CodeCheck.ps1 executes restore.cmd)

So, go ahead but I'd love to know what leads to the errors you saw.

[Tratcher]

False alarm. I figured out that my global nuget.config had one of our feeds listed under disabledPackageSources. aspnetcore's nuget.config clears the global state for packageSources, but not for disabledPackageSources. Should we clear that too?

[ghost]

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 41 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[dougbu]

FYI this isn't really about ./restore.cmd in particular. The Arcade SDK executes dotnet tool restore in the repo root directory (which picks up the config file changed here) as part of every Restore build. So, pretty much every use of our build.* scripts (even with /t:noop) will restore the listed tools.

Separately, the specified dotnet-format version is in the dotnet-tools feed. That works fine because that feed is in our NuGet.config file and automatically used by dotnet tool restore. Still don't get why you were hitting errors @Tratcher

[dougbu]

Oops, missed your "False alarm" @Tratcher 😺

aspnetcore's nuget.config clears the global state for packageSources, but not for disabledPackageSources. Should we clear that too?

I doubt it would hurt but defer to @MattGal because he has done recent work on Maestro++'s automatic NuGet.config changes when we need to reference (but disable by default) internal / infernal feeds. @MattGal any objections to changing from <disabledPackageSources /> (our current state in 'main') to

<disabledPackageSources><clear /></disabledPackageSources>

❔

[MattGal]

@dougbu no objection here. Newly added ones from later automation should be added beneath the last clear found, so barring a bug that shouldn't cause trouble.

[ghost]

Hi @MattGal. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[dougbu]

• [main] Clear disabled package sources #30376
• [master] Clear disabled package sources razor#3188
• [master] Clear disabled package sources ef6#1818
• [main] Clear disabled package sources efcore#24224

@Pilchie what do you think about making similar changes in our Maestro++ servicing branches i.e. 3.1 / 6.4 and 5.0❔ Feels to me like straightforward goodness but I'd appreciate your take.

[Pilchie]

Seems reasonable to me.

[dougbu]

release/3.1 / 6.4:

• [release/3.1] Clear disabled package sources #30400
• [release/3.1] Clear disabled package sources razor#3196
• [release/6.4] Clear disabled package sources ef6#1820
• [release/3.1] Clear disabled package sources efcore#24240

release/5.0:

• [release/5.0] Clear disabled package sources #30401
• [release/5.0] Clear disabled package sources efcore#24241

All but dotnet/ef6#1820 must wait 'til the branches open again i.e. they'll be tell-mode parts of 3,1,14 and 5.0.5.