[6.0-rc2] Fix DatabaseDeveloperPageExceptionFilter to handle wrapped DbExceptions #36803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes EF (or other libraries) wrap database errors. The exception filter should account for this, but was not doing. This was revealed by dotnet/efcore#25050 where we started treating more error numbers as transient and hence wrapping their exceptions. Note that the original Diagnostics.EFCore.FunctionalTests have a test for this, but it appears that these tests were never updated when the mechanism was changed in .NET 5.
ghost
added
the
ajcvickers
changed the title
|
@javiercn @Pilchie RC2 fix for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1399210 The database error page won't show when using EF Core 6.0 RC2 without this fix. It doesn't stop anything else working. That is, if the database is created as normal, then everything else should work. So the reason to get this into RC2 is so that people see the error page and get instructions on what to do. |
|
/cc @AndriySvyryd FYI |
|
"Hi ajcvickers. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
jamshedd
added
Servicing-approved
AndriySvyryd
approved these changes
Sep 21, 2021
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes EF (or other libraries) wrap database errors. The exception filter should account for this, but was not doing. This was revealed by dotnet/efcore#25050 where we started treating more error numbers as transient and hence wrapping their exceptions.
Note that the original Diagnostics.EFCore.FunctionalTests have a test for this, but it appears that these tests were never updated when the mechanism was changed in .NET 5.
Customer Impact
When first creating a site and the DB doesn't exist, you get an error message rather than the custom database page that allows you to create it.
Regression?
Regressed since RC1, as EF started wrapping more exceptions in dotnet/efcore#25050
Risk
Just falls back to
InnerExceptionif the exception isn'tDBException.Verification
Packaging changes reviewed?
Addresses AzDO#1399210