-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Make UseUrls() override default hosting config #39836
Conversation
Hi @halter73. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Hi @halter73. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
/azp run |
We can merge this once CI is green & reviewers have signed off |
Azure Pipelines successfully started running 2 pipeline(s). |
@davidfowl @Tratcher @captainsafia Can one of you give this a review? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@halter73 this breaks in conjunction with dotnet/runtime#63816 - we're going to revert it for now to unblock builds. Can try again next month when there's more time to react. |
…t-efcore dnceng/internal/dotnet-runtime - Revert "Make UseUrls() override default hosting config (#39836)"
Description
Prior to this change, default config (typically loaded from
DOTNET_
/ASPNET_
environment variables and command line arguments) could override the application-level configuration. This would preventGenericWebHostService
from seeing the latest configuration set byUseUrls()
ofDOTNET_URLS
,ASPNET_URLS
or--urls
was set.Fixes #38185
Customer Impact
This is a big gotcha to customers using
WebApplicationBuilder
(which is used in all the ASP.NET Core 6 templates) who expect the following to work:A comment on the issue suggesting we patch this has gotten 5 thumbs ups not counting mine.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
This is a small well tested change which only affects the loading of default config sources and those added via a HostFactoryResolver to host configuration.
Verification
Packaging changes reviewed?