Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming DisableImplicitFromServicesParameters option #40047

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Renaming DisableImplicitFromServicesParameters option #40047

merged 1 commit into from
Feb 8, 2022

Conversation

brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Feb 7, 2022 •
edited
Loading

Renaming DisableImplicitFromServiceParameters to DisableImplicitFromService*s*Parameters

Related #39667

@brunolins16 brunolins16 requested a review from halter73 as a code owner February 7, 2022 20:08
@ghost ghost added the area-signalr Includes: SignalR clients and servers label Feb 7, 2022
@halter73
Copy link
Member

halter73 commented Feb 7, 2022

We'll also want to update aspnet/Announcements#479 and try to make sure this gets in the same preview2 release as the original change. I think code complete is this Friday.

@brunolins16 brunolins16 merged commit 130849a into dotnet:main Feb 8, 2022
@ghost ghost added this to the 7.0-preview2 milestone Feb 8, 2022
@brunolins16 brunolins16 deleted the brunolins16/issues/consolidate-inferservicesoption branch August 2, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
7.0-preview2
Development

Successfully merging this pull request may close these issues.
3 participants
@brunolins16 @halter73 @BrennanConroy